acm-udayton / acm-udayton/ACM-Meeting-Records

[TASK] Migrate business logic to services

未關閉
#160 0 則留言 0 個 reaction 已指派 2 人 已被 @ethanlally 認領 在 GitHub 檢視
enhancement
主要語言
Python
星號
7
分支
2
平均合併
4 天 23 小時
30 天內合併 PR
2

描述

## Feature Description

Business logic should be moved from within the routes and blueprints to separate services. These services should be contained in a `app/services` directory, with files mirroring the blueprints where they would have previously been located.

## Why It's Worth Implementing

Not only does this make our app more consistent with best practices and increase maintainability and testing ease, it also is key to our process of decoupling the frontend and backend. These services will allow us to keep consistent business logic during the intermediate phase where we keep the existing Jinja template serving and also build out the RESTful API.

---

## Acceptance Criteria & Solution Requirements
*To close this issue, the following must be met (can be finalized in the comments):*
- [x] 1. Application runs as expected with the new feature integrated seamlessly.
- [x] 2. Code quality metrics are maintained, and linting has been considered in development.
- [x] 3. Testing metrics are maintained, and tests have been updated/added wherever relevant during development.
- [ ] 4. Documentation has been updated to reflect the changes made during development.
- [ ] 5. All business logic has been removed from the `app/blueprints` directory, and is instead kept in the `app/services` directory.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。