acl-services / acl-services/paprika

<Listbox.Trigger> clear button, provide isSemantic prop

未關閉
#386 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
54
分支
10
平均合併
1 天 12 小時
30 天內合併 PR
6

描述

# Feature request
## Is your feature request related to a problem?
My problem is due to global styles with the clear button in the listbox trigger ``.

## Describe the solution you'd like
We could use the `` instead of the styled component, or provide a way to make it use `` with correct a11y semantics.

## Describe alternatives you've considered
- Alternative right now is to override the global css in consuming app

## Additional context
Screen Shot 2020-01-08 at 2 54 02 PM

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

Start in the source folder for `Listbox.Trigger` and inspect how the clear control is rendered (currently styled as a button). Trace which props flow into that render path and add support for a semantic toggle so consumers can opt out of button semantics/styling behavior. Check Listbox usage docs or examples to add the new usage pattern, then run the Listbox component tests or demos to confirm the clear control is rendered with the expected element/semantics.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript, react
領域
accessibility, frontend
Issue 類型
功能
難度
2/5
預估耗時
1-3 小時
活躍度
停滯
描述清晰度
基本清楚
新手友好度
44/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。