acl-services / acl-services/paprika

Support changing role for Modal

未關閉 適合新手
#355 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
Feature Request Low Priority ↓
主要語言
JavaScript
星號
54
分支
10
平均合併
1 天 12 小時
30 天內合併 PR
6

描述

# Feature request
## Prerequisites
We have Modal component. Currently, Modal component renders `

`.

## Is your feature request related to a problem?
`role="dialog"` is not best solution for some cases.

## Describe the solution you'd like
There is `alertdialog` role – a special-case dialog role designed specifically for dialogs that divert users' attention to a brief, important message.

## Additional context
https://github.com/acl-services/paprika/pull/320#discussion_r357880537

https://www.w3.org/TR/wai-aria-practices-1.1/examples/dialog-modal/alertdialog.html

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

The request targets the Modal component’s rendered role attribute. Start by finding the Modal component source where it outputs `

` and review how props are passed through to the wrapper element. Then identify any modal-related tests or snapshots to update for role output and add coverage for `alertdialog` support. A completed PR should allow consumers to configure role while preserving the existing default and include updated expectations/tests for both cases.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript, react
領域
frontend
Issue 類型
功能
難度
2/5
預估耗時
1-3 小時
活躍度
停滯
描述清晰度
基本清楚
新手友好度
64/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。