acl-services / acl-services/paprika
Popover – RawButton wraps Trigger when not needed
- Linguagem predominante
- JavaScript
- Estrelas
- 54
- Forks
- 10
- Merge médio
- 1d 12h
- PRs com merge (30d)
- 6
Descrição
# Bug Report
## Expected behavior
When a `` is used with the ``, no `` should wrap it. However, sometimes if an `` or other non-interactive element is used for the trigger, it may still be convenient.
## Current behavior
When the `` is given a `node` as `children`, it will always wrap it with a ``. It's necessary to provide a `function` as `children` to avoid this behaviour.
## Examples
``
https://github.com/acl-services/paprika/pull/113#discussion_r302289468
### 📙 Storybook
http://storybooks.highbond-s3.com/paprika/master
Guia de contribuição
Nenhum guia de contribuição indexado para este repositório
Direção de pesquisa
Use the Storybook link in the issue to reproduce the ``/`` behavior and observe current wrapping. Then locate the `Popover.Trigger` implementation and find where node children are automatically wrapped in `RawButton`, adjusting that condition if needed. Check any nearby Popover/trigger stories or tests to keep behavior for non-interactive nodes. Done means button children render without forced `RawButton` wrapping while existing non-button cases still work.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- javascript, react
- Domínio
- frontend
- Tipo de issue
- Bug
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Status de atividade
- Estagnada
- Clareza
- Razoavelmente clara
- Facilidade para iniciantes
- 49/100