acl-services / acl-services/paprika

CollapsibleCard eliminate 'editMode'

Aberta
#1,092 0 comentários 0 reações 0 responsáveis Ver no GitHub
Editor's Choice Low Priority ↓
Linguagem predominante
JavaScript
Estrelas
54
Forks
10
Merge médio
1d 12h
PRs com merge (30d)
6

Descrição

Nahum made a comment in a ticket: https://aclgrc.atlassian.net/browse/UXD-1095?focusedCommentId=302052

>can we remove the concept of isEditing prop in the current CollpasibleCard? and switched it for kind={CollapsibleCard.types.kind.inter'ctive} using the concept `isEditing` don't let room for the component to expand and grow, isEditing is only relevant or make sense during a feature design but doesn't have any functionality in the component apart from just setting the header colour into yellow.

>Removing the concept of editing mode and bringing up the concept for kind gives room to the component to grow organically, for example, if we need a state to mark the card with an error, or if it’s on loading state, we could use the kind property as we use it in the Toast. The other way we will have to incorporate hasError, which doesn’t describe at all what is happening inside of the CollapsibleCard.

>This is part of designing agnostic components and preventing to tide them and mixed them with business logic

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Direção de pesquisa

Start by locating the CollapsibleCard component and its prop/type definitions, then search for `isEditing` references in its source, tests, and docs. Read those points first to map where the current prop controls header styling. Replace that API with the `kind`-based approach described in the issue (for example `interactive`) and remove edit-mode handling. Finish by running the CollapsibleCard-focused tests/build check and confirm no `isEditing` usage remains and `kind` drives the intended state behavior.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
javascript, react
Domínio
frontend
Tipo de issue
Refatoração
Dificuldade
3/5
Tempo estimado
Meio dia
Status de atividade
Estagnada
Clareza
Razoavelmente clara
Facilidade para iniciantes
56/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.