acl-services / acl-services/paprika

CollapsibleCard eliminate 'editMode'

Abierto
#1,092 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Editor's Choice Low Priority ↓
Lenguaje dominante
JavaScript
Estrellas
54
Forks
10
Merge medio
1 d 12 h
PR fusionados (30 d)
6

Descripción

Nahum made a comment in a ticket: https://aclgrc.atlassian.net/browse/UXD-1095?focusedCommentId=302052

>can we remove the concept of isEditing prop in the current CollpasibleCard? and switched it for kind={CollapsibleCard.types.kind.inter'ctive} using the concept `isEditing` don't let room for the component to expand and grow, isEditing is only relevant or make sense during a feature design but doesn't have any functionality in the component apart from just setting the header colour into yellow.

>Removing the concept of editing mode and bringing up the concept for kind gives room to the component to grow organically, for example, if we need a state to mark the card with an error, or if it’s on loading state, we could use the kind property as we use it in the Toast. The other way we will have to incorporate hasError, which doesn’t describe at all what is happening inside of the CollapsibleCard.

>This is part of designing agnostic components and preventing to tide them and mixed them with business logic

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.