acl-org / acl-org/acl-anthology

Test Incorporation

未关闭
#1,839 1 条评论 0 个 reaction 已指派 1 人 已被 @xinru1414 认领 在 GitHub 查看
enhancement
主要语言
Python
星标
797
派生
408
平均合并
3 天 19 小时
30 天内合并 PR
36

描述

Inspired by the recent incidents of change-in-some-scripts resulting in the breaking of other scripts and back-and-forth reversing the change (see https://github.com/acl-org/acl-anthology/commit/8500a12307de69be9b799308dbdf7e57841d9537#r67683715, https://github.com/acl-org/acl-anthology/pull/1836/commits/50531e243ea5b9842cb359c75a2f8851a1b42002 and discussion in https://github.com/acl-org/acl-anthology/pull/1833#issuecomment-1055813438), it seems like we could really use some tests.

While trying to use `pytest` package for the tests, I encountered a problem. The version of`texsoup` package we currently use is ancient and isn't compatible with `pytest`. https://github.com/acl-org/acl-anthology/blob/56145deed72d4b3a43788e5ea7bfe200b12cd2d8/bin/requirements.txt#L18

Upgradinig the `texsoup` version will solve the problem and I think is the best solution (unless for some reason we have to work with the ancient version). Before I dive into changing the code (https://github.com/acl-org/acl-anthology/blob/master/bin/anthology/texmath.py):

- I'm not terribly familiar with texsoup so upgrading the codebase isn't trivia. Any insights/tips that could speed up the process are greatly appreciated!
- Any other suggestions/solutions?

@mjpost @mbollmann

贡献指南

这个仓库没有索引到贡献指南

调研方向

Review the dependency entry in bin/requirements.txt and the TexSoup integration in bin/anthology/texmath.py. Start by checking whether the current TexSoup version is compatible with pytest, then identify the scripts that need coverage from the linked incident context. Done means pytest can be used and tests cover the changes without breaking those scripts.

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
testing-qa, tooling
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。