achingbrain / achingbrain/uint8arraylist

Omit type-checking on append

Abierto
#58 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
11
Forks
9
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Currently on append "instanceof Uint8array" is called on every element, which does have an effect on the performance. It would be ideal instead that append method would only accept Uint8array and utilize Typescript types to make sure we are not appending things of wrong type.

For the case where we want to append UInt8ArrayList, we could have a separate method like, `join` or `merge` to cover that specific case.

For the append-all benchmark I can get 5.9m ops/s without type checking
and 5.5m ops/s with type checking

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.