acacode / acacode/swagger-typescript-api

Enum that are negatives(-) are generated with the same name as positives(+)

Open
#502 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
4.1k
Forks
436
PR merge metrics
No merged PRs in 30d

Description

# Problem

When you have an enum with negatives(-) values and positive(+) values with the same number:

![image](https://user-images.githubusercontent.com/5687655/224488478-18aaac96-ee4f-4fc1-abb7-427bfb7b7f78.png)

It produces an enum with the same name:

![image](https://user-images.githubusercontent.com/5687655/224488449-f00e5d7b-9c36-45e8-a8fd-95590ad402b8.png)

# Possible Solution

For generating names in Enums function need to parse the "-" to a "_" character, it will generate something like this:

![image](https://user-images.githubusercontent.com/5687655/224488558-99849afe-5842-42df-9ec8-8575d828cac0.png)

# Steps to reproduce

- Create a swagger api with enums with a negative and a positive number (with the same number Ex: -1,1 or -2,2 or -3,3 or so on)
- Run the command: `npx swagger-typescript-api -p http://localhost/api-json --extract-enums`
- The generated enum will have the same name for both `-1 and 1`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.