acacode / acacode/swagger-typescript-api

Null values in object being converted to form send "null" to server

未關閉
#485 1 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
TypeScript
星號
4.1k
分支
436
PR 合併指標
30 天內沒有已合併 PR

描述

When a request that uses the content type of `ContentType.FormData` is sent with a body, any null or undefined values in that object end up being sent to the server as `'null'` or `'undefined'` strings. This seems very wrong to make the server add special handling for strings containing the words null or undefined.

The code in question is this:
```ts
[ContentType.FormData]: (input: any) =>
Object.keys(input || {}).reduce((formData, key) => {
const property = input[key];
formData.append(
key,
property instanceof Blob
? property
: typeof property === 'object' && property !== null
? JSON.stringify(property)
: `${property}` // TODO: If property is null or undefined, this will result in 'null' or 'undefined'
);
return formData;
}, new FormData()),
```

The line with the TODO shows the cause of the problem.
I see two ways of fixing this:
1. Wrap the `formData.append` call in a conditional to only add it to the FormData object if the value is not null or undefined.
2. Modify the line with the TODO so that it returns the empty string if `property` is null or undefined instead of blindly converting the value to a string.

To me, option 2 seems more correct since it's likely that purposefully setting a value to null or undefined may be a way of clearing a piece of data in the server; option 1 would not add the data to the form and thus wouldn't send the value to the server.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。