abseil / abseil/abseil-cpp

Does Conan package need to provide the library with 'absl' name?

Aperta
#677 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C++
Stelle
18.1k
Fork
3.2k
Merge medio
20h 36m
PR unite (30g)
1

Descrizione

https://github.com/abseil/abseil-cpp/blob/a1d6689907864974118e592ef2ac7d716c576aad/conanfile.py#L46

I am embarking on the perilous road of packaging gRPC with Conan. gRPC depends on Abseil and
looks for it as
```
abslConfig.cmake
absl-config.cmake
```

The bincrafters abseil/20200205 package contains the following lines at https://github.com/conan-io/conan-center-index/blob/da4c194576212941e63c8de3a81fa07eb02855e1/recipes/abseil/all/conanfile.py#L150
```
self.cpp_info.names["cmake_find_package"] = "absl"
self.cpp_info.names["cmake_find_package_multi"] = "absl"
```

Without those lines, my locally build Conan package from 20200225.2 tag produces:
```
abseilConfig.cmake
abseilConfigVersion.cmake
abseilTarget-release.cmake
abseilTargets.cmake
```

I understand this might be a breaking change, but I suspect there are more users of Abseil out there who call the package by absl.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.