abseil / abseil/abseil-cpp

[Bug][CMAKE][WINDOWS]: missing hardening in CMake/AbseilDll.cmake

Open
#2,140 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
18.1k
Forks
3.2k
Avg merge
20h 36m
Merged PRs (30d)
1

Description

### Describe the issue

in https://github.com/abseil/abseil-cpp/commit/d85c5281b875fd58d86524a0b781c09e3248b216
`absl::hardening` has been added to `absl/base/CMakeLists.txt`.

But it **seems** the AbslDLL.cmake miss some bit aka `hardening` cmake target has not been added to `ABSL_INTERNAL_DLL_TARGETS` in `CMake/AbseilDll.cmake`...
see:
https://github.com/abseil/abseil-cpp/blob/fe690e639469d2a3c86bc74dd2456371288d1f28/CMake/AbseilDll.cmake#L564-L566

### Steps to reproduce the problem

windows cmake build ?

### What version of Abseil are you using?

20260817.0

### What operating system and version are you using?

windows msvc...

### What compiler and version are you using?

cl.exe

### What build system are you using?

cmake

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.