abseil / abseil/abseil-cpp

[Bug]: Cord causes slow builds all over project

Aperta
#1,868 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C++
Stelle
18.1k
Fork
3.2k
Merge medio
20h 36m
PR unite (30g)
1

Descrizione

### Describe the issue

While diagnosing my slow builds in a project that depends on Abseil, I concluded that Cord is the outstanding culprit. I don't use Cord, but I do use flags, and flags depend on flat_hash_map, and flat_hash_map comes with a header that _can_ hash a Cord, and thereby depends on Cord. It would be neat if there was a way to untie this knot so that only Cord users depended on Cord and its hasher.

According to `-ftime-trace` analysis these are the top three most expensive template instantiations for a small portion of my build that really should have been trivial but actually takes 55s to compile:

```
**** Templates that took longest to instantiate:
3932 ms: std::deque::operator= (31 times, avg 126 ms)
3861 ms: std::deque::assign::__assign_wi... (31 times, avg 123 ms)
```

### Steps to reproduce the problem

Use clang's `-ftime-trace` flag in your project that needs Abseil-cpp flags, then analyze the output with ClangBuildAnalyzer.

### What version of Abseil are you using?

HEAD

### What operating system and version are you using?

Ubuntu Linux 24.04

### What compiler and version are you using?

/opt/llvm-19/bin/clang -v
clang version 19.1.7
Target: aarch64-unknown-linux-gnu
Thread model: posix
InstalledDir: /opt/llvm-19/bin
Found candidate GCC installation: /usr/lib/gcc/aarch64-linux-gnu/11
Selected GCC installation: /usr/lib/gcc/aarch64-linux-gnu/11
Candidate multilib: .;@m64
Selected multilib: .;@m64

### What build system are you using?

Bazel 7.6.1

### Additional context

These results are seen with libc++, if that makes a difference.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

The issue points to a compile-time performance problem in Abseil's Cord and flat_hash_map headers. Start by examining the header dependency chain, particularly how flat_hash_map's hasher includes Cord. Look at the Abseil source structure to understand the include relationships. Reproduce the slow build using the provided clang -ftime-trace flag and Bazel. A fix likely involves refactoring header dependencies to avoid forcing Cord compilation on non-Cord users.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
cpp
Ambito
build-system, performance
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.