abseil / abseil/abseil-cpp

dynamic_annotations symbols in the global namespace

Aperta
#122 5 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C++
Stelle
18.1k
Fork
3.2k
Merge medio
20h 36m
PR unite (30g)
1

Descrizione

Abseil dynamic_annotations (https://github.com/abseil/abseil-cpp/blob/master/absl/base/dynamic_annotations.h, https://github.com/abseil/abseil-cpp/blob/master/absl/base/dynamic_annotations.cc) define macros and functions without ABSL_ or Absl prefix (this is C code, so we cannot use namespaces).

This behavior can cause ODR violations and macros clashing. A possible solution would be to prefix all the macros with ABSL_ and all the functions with Absl. This will make Abseil compatible also with projects that are using something like https://code.google.com/archive/p/data-race-test/wikis/DynamicAnnotations.wiki.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.