abseil / abseil/abseil-cpp

Abseil pkgconfig leads to too many arguments

Aperta
#1,168 7 commenti 0 reazioni 1 assegnatario Rivendicata da @suertreus Vedi su GitHub
bug
Lingua principale
C++
Stelle
18.1k
Fork
3.2k
Merge medio
20h 36m
PR unite (30g)
1

Descrizione

Including the pkgconfig from abseil results in hundreds of CFLAGS many of which are redundant. I believe they could be restructured to have one common pkconfig that is added to "requires" so the CFLAGS are only included once.

Here is an example of the CFLAGS that are repeated:
```
-DNOMINMAX
-Wno-float-conversion
-Wno-implicit-float-conversion
-Wno-implicit-int-float-conversion
-Wno-implicit-int-conversion
-Wno-shorten-64-to-32
-Wno-sign-conversion
-Wno-unknown-warning-option
```

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.