abseil / abseil/abseil-cpp

Abseil pkgconfig leads to too many arguments

Open
#1,168 7 comments 0 reactions 1 assignee Claimed by @suertreus View on GitHub
bug
Dominant language
C++
Stars
18.1k
Forks
3.2k
Avg merge
20h 36m
Merged PRs (30d)
1

Description

Including the pkgconfig from abseil results in hundreds of CFLAGS many of which are redundant. I believe they could be restructured to have one common pkconfig that is added to "requires" so the CFLAGS are only included once.

Here is an example of the CFLAGS that are repeated:
```
-DNOMINMAX
-Wno-float-conversion
-Wno-implicit-float-conversion
-Wno-implicit-int-float-conversion
-Wno-implicit-int-conversion
-Wno-shorten-64-to-32
-Wno-sign-conversion
-Wno-unknown-warning-option
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.