abrignoni / abrignoni/iLEAPP

Module Data not Recorded with Empty `source_path`

Offen
#1,214 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
Python
Sterne
1.2k
Forks
303
Ø Merge
4 Std. 32 Min.
Gemergte PRs (30 T.)
216

Beschreibung

@stark4n6 reported that a module he was working on was returning no data and logging "no file found" to the console, but the module had provided parsed data. since the data was coming from multiple source files, he added a column in the data to state which source each record came from and left the `source_path` return value to be empty.

the line creating the potential issue:
https://github.com/JamesHabben/iLEAPP/blob/e74f7507564b64e5b78810dabc6931a26c247a90/scripts/ilapfuncs.py#L361-L362

@Johann-PLW added this most recently, so want to get him to weigh in on if this is intended. do we want to allow an empty `source_path` value or enforce that there is something in the value even if to state 'look at source column' or something?

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.