abrignoni / abrignoni/iLEAPP

Module Data not Recorded with Empty `source_path`

Aperta
#1,214 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
Python
Stelle
1.2k
Fork
303
Merge medio
4h 32m
PR unite (30g)
216

Descrizione

@stark4n6 reported that a module he was working on was returning no data and logging "no file found" to the console, but the module had provided parsed data. since the data was coming from multiple source files, he added a column in the data to state which source each record came from and left the `source_path` return value to be empty.

the line creating the potential issue:
https://github.com/JamesHabben/iLEAPP/blob/e74f7507564b64e5b78810dabc6931a26c247a90/scripts/ilapfuncs.py#L361-L362

@Johann-PLW added this most recently, so want to get him to weigh in on if this is intended. do we want to allow an empty `source_path` value or enforce that there is something in the value even if to state 'look at source column' or something?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.