aboutcode-org / aboutcode-org/vulnerablecode

fix: Replace bare [except] (vulnerabilities/tests/test_bare_except_fix.py) with explicit `Exception` in import_runner.py

Abierto
#2,070 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
702
Forks
328
Merge medio
3 d 8 h
PR fusionados (30 d)
3

Descripción

## Summary

The file [vulnerabilities/import_runner.py] contains a bare `except:` clause at line 222 which violates PEP 8 (E722) and can lead to unexpected behavior.

## Problem

Bare `except:` clauses catch **all** exceptions, including:
- `SystemExit` - prevents clean program termination
- `KeyboardInterrupt` - prevents Ctrl+C from working
- `GeneratorExit` - can break generator cleanup

This is almost never the intended behavior and can mask critical errors or make debugging difficult.

## Location

**File:** [vulnerabilities/import_runner.py](cci:7://file:///D:/Projects2.0/Gsoc/vulnerablecode/vulnerabilities/import_runner.py:0:0-0:0)
**Line:** 222
**Current code:**
```python
except:
logger.error(
f"Failed to create VulnerabilitySeverity for: {severity} with error:\n{traceback_format_exc()}"
)

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.