aboutcode-org / aboutcode-org/vulnerablecode

Package details page URLs use '?' rather than '%3F', and VCIO disregards the portion of the PURL starting with '?'

Aperta
#1,530 3 commenti 0 reazioni 1 assegnatario Rivendicata da @johnmhoran Vedi su GitHub
data-quality ui
Lingua principale
Python
Stelle
702
Fork
328
Merge medio
3g 8h
PR unite (30g)
3

Descrizione

While working on https://github.com/nexB/vulnerablecode/issues/1287, I noticed that when the results of a UI Package search query for a PURL with a qualifier include a PURL with a qualifier, the PURL displayed in the Package search results list uses '?' as the separator indicating that a qualifier follows, but the actual URL uses the ASCII-encoded '%3F'. Clicking such a link takes the user to the intended Package details page for the PURL with a qualifier.

However, the URLs displayed on the Package details page for any PURL with a qualifier use '?' rather than '%3F'. As a result, clicking such a link does not take the user to the page for the PURL with the qualifier. Instead, VCIO disregards that portion of the URL that starts with '?' -- if the PURL string up to the '?' identifies a Package in the database, clicking that link takes the user to that PURL *without* a qualifier, but if there is no such PURL in the database, a page-not-found/404 is returned instead.

A quick check of the API suggests there is no similar issue with the URL or PURL data there but this needs a more thorough check to be certain.

Related issues:
- https://github.com/nexB/vulnerablecode/issues/1508
- https://github.com/nexB/vulnerablecode/issues/1287

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.