aboutcode-org / aboutcode-org/univers

Inconsistent use of `attr` parameter and `__eq__` in VersionConstraint

Open
#43 0 comments 0 reactions 0 assignees View on GitHub
2-next bug good first issue
Dominant language
Python
Stars
50
Forks
29
PR merge metrics
No merged PRs in 30d

Description

For `__eq__` method to take effect, `eq=False` must be added as a attr parameter
https://github.com/nexB/univers/blob/7206c1fc35eb32d0006591e6defcc65ded40cfa0/src/univers/version_constraint.py#L123-L127
Something like this:
```python
@attr.s(frozen=True, repr=True, str=False, order=False, eq=False, hash=True)
```
Current attr paramaters:
https://github.com/nexB/univers/blob/7206c1fc35eb32d0006591e6defcc65ded40cfa0/src/univers/version_constraint.py#L55-L56

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.