aboutcode-org / aboutcode-org/univers

maven.py: "release" qualifier not treated as release alias

Open
#188 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
50
Forks
29
PR merge metrics
No merged PRs in 30d

Description

What: `ALIASES` dict in `maven.py` maps `"ga"` and `"final"` to `""` but omits `"release"`. So `Version("1.0") ==
Version("1.0-release")` returns `False`.

Expected: The Maven `ComparableVersion` spec defines `""`, `"final"`, `"ga"`, and `"release"` as equivalent.
Reference: https://maven.apache.org/pom.html#version-order-specification

Fix: Add `"release": ""` to the `ALIASES` dict on line 33 of `univers/maven.py`.

Reproduction:
```from univers.maven import Version
assert Version("1.0") == Version("1.0-release") # fails
assert Version("1.0") == Version("1.0-final") # passes
assert Version("1.0") == Version("1.0-ga") # passes
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.