aboutcode-org / aboutcode-org/source-inspector

xgettext: process files with spaces and colons in the filename

Offen
#18 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
C
Sterne
3
Forks
2
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

From #16 (comments)

So what about file names that have a space in it, or perhaps have a semicolon? Those are valid file names and `xgettext` will happily process them and you will get something like this (I just renamed a file and then ran `xgettext`):

```
#: fdisk:big.c:234 fdisk:big.c:2942
```

I am not sure how common file names with semicolons are, but file names with spaces are not uncommon.

As far as I can tell `partition()` will not properly process this:

```
>>> _, _, bla = a.partition('#:')
>>> bla.partition(':')
(' fdisk', ':', 'big.c:234 fdisk:big.c:2942')
```

The only certainty that you have is that the part after the last : should be a number, so perhaps rewriting it to rpartition() would be the cleanest way.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.