aboutcode-org / aboutcode-org/scancode-toolkit

Some license test files are masking each other

Offen
#5,257 3 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
2.6k
Forks
791
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
5

Beschreibung

The following RULE file pairs have the same generated validation test method name, hence masking each other:
- `cnri-python-1.6.1.RULE` and `cnri-python-1.6_1.RULE` have both a validation test method `cnri_python_1_6_1_rule`
- same with `proprietary-10.RULE` and `proprietary_10.RULE` with a a validation test method of `proprietary_10_rule`

See:
- https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/cnri-python-1.6.1.RULE
- https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/cnri-python-1.6_1.RULE
- https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/proprietary-10.RULE
- https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/proprietary_10.RULE

We should:
1. rename one of the rules in each pair
2. add a new test to avoid this issue in the future

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.