aboutcode-org / aboutcode-org/scancode-toolkit

Some license test files are masking each other

Open
#5,257 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
2.6k
Forks
791
Avg merge
1d 12h
Merged PRs (30d)
5

Description

The following RULE file pairs have the same generated validation test method name, hence masking each other:
- `cnri-python-1.6.1.RULE` and `cnri-python-1.6_1.RULE` have both a validation test method `cnri_python_1_6_1_rule`
- same with `proprietary-10.RULE` and `proprietary_10.RULE` with a a validation test method of `proprietary_10_rule`

See:
- https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/cnri-python-1.6.1.RULE
- https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/cnri-python-1.6_1.RULE
- https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/proprietary-10.RULE
- https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/proprietary_10.RULE

We should:
1. rename one of the rules in each pair
2. add a new test to avoid this issue in the future

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.