aboutcode-org / aboutcode-org/scancode-toolkit

Ensure viskores license is detected correctly with extra rules

Đang mở
#4,507 2 bình luận 1 reaction 0 người được giao Xem trên GitHub
new-updated-license-rule
Ngôn ngữ chính
Python
Star
2.6k
Fork
791
Merge trung bình
1 ngày 12 giờ
Pull request đã merge (30 ngày)
5

Mô tả

Reported by @opoplawski and discussed with @richardfontana on the Fedora legal mailing list:
https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/NEF754GWMNKY2YJ4CSWQG4472IHPPGX7/

This is a plain BSD-3-Cluase license that has been given another name by @vicentebolea

See for notices that may need some love to be detected correctly
- https://github.com/Viskores/viskores/blob/537a4a91a38fc6e1fa783369f458fcf6bbc1e8a9/CMake/ViskoresDeviceAdapters.cmake#L1

```
## The contents of this file are covered by the Viskores license. See
## LICENSE.txt for details.
##
## By contributing to this file, all contributors agree to the Developer
## Certificate of Origin Version 1.1 (DCO 1.1) as stated in DCO.txt.
```

The license text itself at https://raw.githubusercontent.com/Viskores/viskores/refs/heads/main/LICENSE.txt is detected correctly as a BSD-3-Clause by ScanCode, with one word (AUTHORS) not matched, so we could add one rule for that:

> matched_text_diagnostics: |
> Redistribution and use in source and binary forms, with or without
> modification, are permitted provided that the following conditions are
> met:
>
> * Redistributions of source code must retain the above copyright
> notice, this list of conditions and the following disclaimer.
>
> * Redistributions in binary form must reproduce the above copyright
> notice, this list of conditions and the following disclaimer in the
> documentation and/or other materials provided with the
> distribution.
>
> * Neither the name of **[Kitware]** nor the names of any contributors may
> be used to endorse or promote products derived from this software
> without specific prior written permission.
>
> THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE **[AUTHORS]** OR
> CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
> EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
> PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
> PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
> LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
> NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

@alok1304 ... this could be a nice test case for your project.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.