aboutcode-org / aboutcode-org/scancode-toolkit

Improve license detection for wrong SPDX license identifiers

Aperta
#3,912 3 commenti 0 reazioni 1 assegnatario Rivendicata da @AyanSinhaMahapatra Vedi su GitHub
improve-license-detection license scan
Lingua principale
Python
Stelle
2.6k
Fork
791
Merge medio
1g 12h
PR unite (30g)
5

Descrizione

Consider the following text:
```
SPDX-License-Identifier: (GPL-2.0+ OR BSD)
```

Here `BSD` is not a valid license expression and even adding a rule is insufficient because the `SPDX-License-Identifier` based detection was moved before the hash license detection.

We should either:
1. do the hash license detection first so we can catch these with rules, and then do the SPDX identifier based detection
2. if we get unknown-spdx we consider license detection with rules
3. Also optionally consider license detection with required phrase rules if nothing works (would lose license expression info for this potentially)?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.