aboutcode-org / aboutcode-org/scancode-toolkit

Not skipping node_modules directory

Đang mở
#3,775 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
bug
Ngôn ngữ chính
Python
Star
2.6k
Fork
791
Merge trung bình
1 ngày 12 giờ
Pull request đã merge (30 ngày)
5

Mô tả

### Description
While scanning my node.js codebase, I could see it scan the node_modules directory as well, which is not necessary and time consuming.

### How To Reproduce
![image](https://github.com/nexB/scancode-toolkit/assets/57087973/4530efe6-6bc1-4897-80d5-299f9c5c820d)

Snapshot 1: Codebase where node_modules was scanned

![image](https://github.com/nexB/scancode-toolkit/assets/57087973/ae2315b2-9b05-469a-a9f1-6f2dd2c6ca17)

Snapshot 2: Codebase where `npm install` was not done (node_modules directory doesn't exist)

### Thoughts
This seems to be not working:
```
for child in resource.children(codebase):
if depth == 0 and child.name == 'node_modules':
continue
yield child
```

> For bug reports, it really helps us to know:

* What OS are you running on? (Windows/MacOS/Linux) - Windows 11
* What version of scancode-toolkit was used to generate the scan file? - v32.1.0-7-g4f49985c26
* What installation method was used to install/run scancode? (pip/source download/other) - source download

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.