aboutcode-org / aboutcode-org/scancode-toolkit

Unknowns in widnows manifests not relevant?

Abierto
#3,603 1 comentario 0 reacciones 0 asignados Ver en GitHub
improve-license-detection
Lenguaje dominante
Python
Estrellas
2.6k
Forks
791
Merge medio
1 d 12 h
PR fusionados (30 d)
5

Descripción

There are a lot of windows-type manifests (like type: `winexe`) detected in SCTK which have extracted license statements like the following:
```
{'LegalCopyright': 'Copyright (C) Microsoft Corporation. All rights reserved.', 'LegalTrademarks': '', 'License': None}
```
And these are detected as: ``"declared_license_expression": "unknown",``
Here's an example in our test data: https://github.com/nexB/scancode-toolkit/blob/develop/tests/packagedcode/data/plugin/com-package-expected.json#L41, more are present.
Since this is a copyright and then no license is specified, is this really an Unknown license?
Should we just ignore if we have a `'License': None` here and have `None` in the license fields instead?

@pombredanne @JonoYang RFC

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.