aboutcode-org / aboutcode-org/scancode-toolkit

Restore detecting copyright of ICC color profile with an option

Offen
#3,551 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
copyright scan
Vorherrschende Sprache
Python
Sterne
2.6k
Forks
791
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
5

Beschreibung

Based on a chat with @pabs3 we should consider to restore detecting copyright of ICC color profile with an option to enable this. This was disabled in https://github.com/nexB/typecode/commit/67b979cf3c9ca72243d53f074eaed0fa53001e0e because of the noise.

For reference, the file discussed here is at https://foss.heptapod.net/openpyxl/openpyxl/-/raw/branch/3.1/openpyxl/formatting/tests/data/conditional-formatting.xlsx?inline=false and in the attached zip

I ran `extractcode --all-formats` then a copyright scan on this. Returning True at the line https://github.com/nexB/typecode/commit/67b979cf3c9ca72243d53f074eaed0fa53001e0e#diff-fe57a9754f1fe16f6436e4fbf8d61ba7b8ec17e67f403dc2d32ca2e6eadeed0cR541 is enough to detect the "Copyright 2007 Apple Inc., all rights reserved." copyright as before.

Here is a mildly edited chatlog:

>> `` https://bugs.debian.org/1053672 - wonder if any tools can detect that; Apple copyright on an ICC profile in the EXIF data in a JPEG file, in a ZIP file with extension .xlsx

> `` FWIW, ScanCode was able to detect ICC copyrights in JPEG files, but that feature was silenced a few years ago as this is extremely noisy in practice and 1/2 of the JPEG of the world have some ICC color profile ??!!@?!# copyright from Apple, or some other places
> See also https://github.com/lovell/sharp/issues/486

> `` why turn it off pombreda ?

> `` Roughly 1/2 of all JPEG in the world have similar issue. It annoyed supremely every user and is practically impossible to remediate making it a double whammy
> The issue for instance here is that a user CANNOT control what Excel or Apple Number or some image tool may do wrt. color profile
> and they do not know and they cannot do anything for things they do know and cannot fix

> `` yeah, ack. widespread problem I guess
> also can the feature be turned back on with an option?

> `` yes, this would be simple enough

> `` ok, that would be good, for generating debian/copyright, or for other people who want pedantic level copyright info

> `` do you know what licenses these Apple ICC profiles are under btw?

> `` good luck with this :) that's likely a speleo expedition!
so no
I question if this is even valid, and if the JPEG images even have these profiles inside at all
though they seem effectively embedded in some segments of a JPEG image

> `` yeah, ICC gets copied into the EXIF metadata in JPEGs
very rarely is it outside images, there are some Debian packages with bare *.icc profile files though

> `` since the icc file is a system apple file from "/System/Library/ColorSync/Profiles/Generic RGB Profile.icc" it has to be a proprietary/commercial license IMHO

[conditional-formatting.xlsx.zip](https://github.com/nexB/scancode-toolkit/files/12926372/conditional-formatting.xlsx.zip)

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.