aboutcode-org / aboutcode-org/python-publicsuffix2

Including upstream list as submodule/subtree would be more transparent

オープン
#13 コメント 3 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Python
スター
30
フォーク
16
PR マージ指標
30日以内にマージされた PR はありません

説明

~~During packaging of python-publicsuffix2 I realized, that downloading the publicsuffix list during build time makes it unreproducible (any time the package is rebuilt, it will have a different list).~~

My suggestion would be to include the publicsuffix list from [upstream](https://github.com/publicsuffix/list/blob/master/public_suffix_list.dat) directly as e.g. a [git submodule](https://github.com/publicsuffix/list/blob/master/public_suffix_list.dat) or [git subtree](https://git-memo.readthedocs.io/en/latest/subtree.html) (the latter is preferred as this way the files actually end up in an automatically generated tarball on github when tagging a release) and not download it ~~during build time~~ at all to ~~ensure reproducibility~~ raise transparency.
The data lives in this repository already, so it could also be copied manually, but IMHO a subtree or submodule is the more transparent way of dealing with this.

~~Currently only the wheel on pypi.org is really ensured to carry the currently bundled version of the publicsuffix list. For anyone else building this package, this assumption is not valid.~~

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。