aboutcode-org / aboutcode-org/python-publicsuffix2

tests missing in sdist/ incoherent tagging vs tarball naming

Open
#12 6 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
30
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Hi! I'm packaging python-publisuffx2 for Arch Linux and would like to be able to run tests from the sdist tarball on pypi.
Although the test files should be included (according to MANIFEST.in), they are not.

As a test I've checked out the current latest version (release-2.2019-12-21) and ran `python setup.py sdist` myself. The files are included in the created sdist tarball, which makes me wonder how the sdists for pypi.org were created.

It would be great, if the sdists included the tests, as currently I have to use the github tarballs to be able to run the tests.

This leads me to the second topic: The tag naming and resulting tarballs are incoherent and lead to more complicated string substitutions to track upstream and/or use the github source tarball vs. using pypi's sdist tarball: `release-2.2019-12-21` -> `publicsuffix2-2.20191221.tar.gz`
I understand, that the tagging scheme so far follows an ISO standard for the date, but it would be more coherent to strip the hyphens to be in line with the resulting tarball/wheel: e.g. `release-2.20191221` -> `publicsuffix2-2.20191221.tar.gz`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.