abiosoft / abiosoft/colima

Underscore in profile name prevents k8s node registration

Abierto
#745 0 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
Go
Estrellas
30.8k
Forks
613
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

### Description

Creating a new Kubernetes VM with an underscore `_` in the profile name causes the node registration to fail. Node names need to be RFC 1123 compliant.

### Version

Colima Version: `0.5.5`
Lima Version: `0.16.0`
Qemu Version: `8.0.0`

### Operating System

- [ ] macOS Intel <= 12 (Monterrey)
- [ ] macOS Intel >= 13 (Ventura)
- [ ] macOS M1 <= 12 (Monterrey)
- [X] macOS M1 >= 13 (Ventura)
- [ ] Linux

### Output of `colima status`

```
$ colima status -p foo_bar
INFO[0000] colima [profile=foo_bar] is running using QEMU
INFO[0000] arch: aarch64
INFO[0000] runtime: containerd
INFO[0000] mountType: sshfs
INFO[0000] kubernetes: enabled
```

### Reproduction Steps

1. `colima start -p foo_bar --kubernetes -r containerd`
2. `colima ssh`
3. View the k3s log file: `less /var/log/k3s.log`

```
E0627 20:00:38.698958 3567 kubelet_node_status.go:92] "Unable to register node with API server" err="Node \"colima-foo_bar\" is invalid: metadata.name:
Invalid value: \"colima-foo_bar\": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and
must start and end with an alphanumeric character
(e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')" node="colima-foo_bar"
```

(^^^ edited log line for formatting)

### Expected behaviour

Colima's config could either enforce an RFC 1123 compliant profile name, or replace incompatible characters in the node name.

### Additional context

_No response_

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.