abiosoft / abiosoft/colima

Underscore in profile name prevents k8s node registration

Open
#745 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
30.8k
Forks
613
PR merge metrics
No merged PRs in 30d

Description

### Description

Creating a new Kubernetes VM with an underscore `_` in the profile name causes the node registration to fail. Node names need to be RFC 1123 compliant.

### Version

Colima Version: `0.5.5`
Lima Version: `0.16.0`
Qemu Version: `8.0.0`

### Operating System

- [ ] macOS Intel <= 12 (Monterrey)
- [ ] macOS Intel >= 13 (Ventura)
- [ ] macOS M1 <= 12 (Monterrey)
- [X] macOS M1 >= 13 (Ventura)
- [ ] Linux

### Output of `colima status`

```
$ colima status -p foo_bar
INFO[0000] colima [profile=foo_bar] is running using QEMU
INFO[0000] arch: aarch64
INFO[0000] runtime: containerd
INFO[0000] mountType: sshfs
INFO[0000] kubernetes: enabled
```

### Reproduction Steps

1. `colima start -p foo_bar --kubernetes -r containerd`
2. `colima ssh`
3. View the k3s log file: `less /var/log/k3s.log`

```
E0627 20:00:38.698958 3567 kubelet_node_status.go:92] "Unable to register node with API server" err="Node \"colima-foo_bar\" is invalid: metadata.name:
Invalid value: \"colima-foo_bar\": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and
must start and end with an alphanumeric character
(e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')" node="colima-foo_bar"
```

(^^^ edited log line for formatting)

### Expected behaviour

Colima's config could either enforce an RFC 1123 compliant profile name, or replace incompatible characters in the node name.

### Additional context

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.