abiosoft / abiosoft/colima

clone command fails to copy VM configuration.

Offen
#1,111 2 Kommentare 4 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Go
Sterne
30.8k
Forks
613
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Using `colima clone` command to move profiles around. While doing so, encountered the following error:

```
colima clone default clone
INFO[0000] preparing to clone colima...
INFO[0000] cloning virtual machine...
INFO[0029] copying config...
cp: /Users/j/.colima/_lima/colima is a directory (not copied).
FATA[0029] error copying VM config: exit status 1
```

Looking at the code, it appears the `cp` command is called on two directories, but without a `-r` flag to recurse the source directory. This causes the failure above. The code in question is:

https://github.com/abiosoft/colima/blob/73732ae8e44148b6191406f61044eff8195ae29b/cmd/clone.go#L66

Now, in the preceding code, the target directory is created and specific files are copied:

https://github.com/abiosoft/colima/blob/73732ae8e44148b6191406f61044eff8195ae29b/cmd/clone.go#L26-L52

So a recursive `-r` flag on the subsequent copy in Line 66 might not be the proper way to fix this, as it would copy for a second time the files copied in lines 26-52.

The second `cp` could copy specific named files like the prior copy. Or could do a recursive copy but delete any unwanted files such as `*.log` and `*.sock`.

I haven't created a PR because I do not have a confirmed way to test the code on my platform (MacOS via Homebrew), but could try if I received some guidance on how and this would speed up a fix.

Thanks,
Jason

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.