abhichaudharii / abhichaudharii/jiosaavn-python

Non async function

Open
#3 4 comments 0 reactions 0 assignees View on GitHub
bug enhancement good first issue
Dominant language
Python
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

I am trying to retrieve songs from a playlist and here's the function that I have right now (running it in Jupyter notebook):

```python
import json
import asyncio
from jiosaavn import JioSaavn
import nest_asyncio

saavn = JioSaavn()
nest_asyncio.apply()

# Define a function to get playlist songs by id
async def get_playlist_songs(playlist_url):
# Use the async method from saavn
songs = await saavn.get_playlist_songs(playlist_url)
# Return a list of songs with details
return songs

playlist_url = "https://www.jiosaavn.com/featured/weekly-top-songs/8MT-LQlP35c_"
data = asyncio.run(saavn.get_playlist_songs(playlist_url, page=1, limit=100))
```
It works but gives me a warning `UserWarning: Unclosed . See https://www.python-httpx.org/async/#opening-and-closing-clients for details.`

A couple of questions for you:
1. How would you modify the code to run without using `asyncio`? I tried a few combinations but I kept getting errors. Appreciate your input.
2. Can we remove `page=1, limit=100` from the `get_playlist_songs` function call?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.