abetlen / abetlen/llama-cpp-python

ROCM Build Target or Build Instructions are incorrect

Aperta
#1,880 2 commenti 3 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
10.6k
Fork
1.4k
Metriche di merge delle PR
Metriche PR in attesa

Descrizione

It seems that at some point the build target for ROCM was renamed from HIPBLAS to HIP. I'm not sure if this was inadvertent or deliberate, but either way, the build instructions for ROCM are incorrect. The README says to use:

```CMAKE_ARGS="-DGGML_HIPBLAS=on" pip install llama-cpp-python```

However, to successfully build ROCM, the command is actually:

```CMAKE_ARGS="-DGGML_HIP=on" pip install llama-cpp-python```

This is obviously a fairly trivial fix, but I haven't created a PR as I'm not sure if it's the docs or the build target name that is incorrect.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.