abetlen / abetlen/llama-cpp-python

install target fails for llava

Abierto
#1,481 10 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
10.6k
Forks
1.4k
Métricas de merge de PR
Métricas de PR pendientes

Descripción

# Prerequisites

Please answer the following questions for yourself before submitting an issue.

- [x] I am running the latest code. Development is very rapid so there are no tagged versions as of now.
- [x] I carefully followed the [README.md](https://github.com/abetlen/llama-cpp-python/blob/main/README.md).
- [x] I [searched using keywords relevant to my issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/filtering-and-searching-issues-and-pull-requests) to make sure that I am creating a new issue that is not already open (or closed).
- [x] I reviewed the [Discussions](https://github.com/abetlen/llama-cpp-python/discussions), and have a new bug or useful enhancement to share.

# Expected Behavior
I was building from source specifically version 0.2.76

make build should have built all the required stuff

# Current Behavior

build install step fails at llava example due to some path variations (not sure what is wrong where though)
```
-- Installing: /home/bargo/projects/rocm-setup/llama-cpp-python/llama_cpp/libllama.so
CMake Error at /tmp/tmpigzjrup0/build/vendor/llama.cpp/examples/llava/cmake_install.cmake:46 (file):
file INSTALL cannot find
"/tmp/tmpigzjrup0/build/vendor/llama.cpp/examples/llava/libllava.so": No
such file or directory.
Call Stack (most recent call first):
/tmp/tmpigzjrup0/build/cmake_install.cmake:128 (include)

*** CMake install failed
error: subprocess-exited-with-error

× Building editable for llama_cpp_python (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> See above for output.

```
# Environment and Context

As build have successfully completed for both llama.pp and for the binding except that installing them have failed, I believe it should not matter on the environment that much (but im running rocm 6.1.1 built from source as well)
* Physical (or virtual) hardware you are using, e.g. for Linux:
Physical linux machine
`$ lscpu`
AMD ryzen 2700x
* Operating System, e.g. for Linux:
Linux 22.04 with built from source kernel 6.4
`$ uname -a`
`Linux bargos 6.4.0bargos #9 SMP PREEMPT_DYNAMIC Sun May 19 17:44:55 CEST 2024 x86_64 GNU/Linux
`
* SDK version, e.g. for Linux:

```
$ python3 --version
$ make --version
$ g++ --version
```

# Failure Information (for bugs)

what have been failed to be found llava shared library actually have already been built and its located in two locations;

```
llama-cpp-python$ find . -name libllava.so
./build/vendor/llama.cpp/examples/llava/libllava.so
./llama_cpp/libllava.so
```

# Steps to Reproduce

1. git clone
2.` pip3 install . OR CMAKE_ARGS="-D LLAMA_HIPBLAS=ON -D CMAKE_C_COMPILER=/opt/rocm/llvm/bin/clang -D CMAKE_CXX_COMPILER=/opt/rocm/llvm/bin/clang++ -D CMAKE_PREFIX_PATH=/opt/rocm" make build -j 8
`

# To mitigate it right now:

I'm just skipping the llava build

`option(LLAVA_BUILD "Build llava shared library and install alongside python package" ON)
`
by passing OFF

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.