abetlen / abetlen/llama-cpp-python

Implementation of LlamaDiskCache lacks capacity setting.

Ouverte
#1,402 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
10.6k
Forks
1.4k
Métriques de merge des PR
Métriques de PR en attente

Description

LlamaDiskCache utilizes diskcache module to hold cache.
While LlamaDiskCache.\_\_init\_\_ can have capacity setting, it's not passed to diskcache.Cache.\_\_init\_\_, which is causing capacity mismatch, and it fails to store data of size greater than 1GB (default capacity of diskcache).

Current implementation:
```python
class LlamaDiskCache(BaseLlamaCache):
"""Cache for a llama.cpp model using disk."""

def __init__(
self, cache_dir: str = ".cache/llama_cache", capacity_bytes: int = (2 << 30)
):
super().__init__(capacity_bytes)
self.cache = diskcache.Cache(cache_dir)
```

This I guess is required:
```python
class LlamaDiskCache(BaseLlamaCache):
"""Cache for a llama.cpp model using disk."""

def __init__(
self, cache_dir: str = ".cache/llama_cache", capacity_bytes: int = (2 << 30)
):
super().__init__(capacity_bytes)
self.cache = diskcache.Cache(cache_dir, size_limit=capacity_bytes) # Added size_limit configuration.
```

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.