abe33 / abe33/atom-pigments

Pigments not showing colors past window height.

Aberta
#333 13 comentários 3 reações 0 responsáveis Ver no GitHub
bug
Linguagem predominante
CoffeeScript
Estrelas
518
Forks
70
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

This is specific to color coding with any of the dot options (dot, square, gutter). The highlight options still work correctly.

After a recent update, pigments stopped showing colors after the first 52 *visible* lines of the file. An older install of atom (0.39 and 0.13) works just fine on the same files). This is specifically happening at line 52 with the font set to 12px. Changing the font size or line height move the break point up and down. Math works out to failing at 936 pixels or thereabouts, seemingly no more meaningful that 52 lines of text.
![image](https://user-images.githubusercontent.com/1514228/29190886-b69ffe32-7de9-11e7-8ea4-2e84321af627.png)

If the line height does not evenly divide into 936, then the break occurs mid-line with an alpha-box blow where the color breaks. Collapsing lines moves the break point down correspondingly.

![image](https://user-images.githubusercontent.com/1514228/29190609-d5bbc5d6-7de8-11e7-9a7f-ef83e9f765df.png)

This occurs for all file types tested so far (SCSS, CSS, HTML, PHP).

No idea if it is pigments or atom 1.19. Other packages are acting wonky, but usually with error popups.

```
Pigments 0.40.2
Atom 1.19.0
Windows 10 Pro 15063.502
```

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

The bug is in the rendering of color dots/squares/gutter markers after a certain pixel height (936px, ~52 lines). Look at the pigments package's view rendering code, likely in lib/pigments-view.coffee or similar. Start by reproducing the issue in Atom 1.19 with a test file, then trace how markers are drawn relative to the editor's visible viewport. Check for hardcoded height limits or canvas sizing. 'Done' is when color markers appear consistently past line 52 across font sizes.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
coffeescript
Domínio
desktop, devtools
Tipo de issue
Bug
Dificuldade
3/5
Tempo estimado
1-2 dias
Status de atividade
Estagnada
Clareza
Razoavelmente clara
Facilidade para iniciantes
45/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.