abcxyz / abcxyz/guardian

Have guardian add comment to PR when apply fails due to plan being more than 7 days old

Ouverte
#416 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
Go
Étoiles
26
Forks
7
Merge moyen
1 j 1 h
PR mergées (30 j)
1

Description

### TL;DR

Have guardian add comment to PR when apply fails due to plan being more than 7 days old. Currently in this scenario the terraform apply fails but there's no notification in the PR that something went wrong

### Detailed design

```markdown

```

### Alternatives considered

```markdown

```

### Additional information

Scenario:

1. PR is created, all checks passed (including guardian)
2. More than 7 days later the PR is reviewed and merged
3. Terraform apply fails to due the plan no longer existing
4. No notification in the PR comment thread
5. Developer at some point notices that there's an issue and has to troubleshoot (maybe seeing that a workflow failed)
6. Developer pushes a noop commit to regenerate the plan and then merges the change.

Desired behavior: Guardian adds a comment to the PR to notify developers that something went wrong (ideally suggesting the source of the issue)

If needed we can provided a PR + Workflow examples in a non-public repo.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Look for the guardian code that handles terraform apply failures, likely in a GitHub Actions workflow or a guardian command. Find where the plan age is checked and the apply fails. Add logic to post a comment to the PR via the GitHub API when this condition triggers. Check existing PR comment functions and error handling patterns. Test by simulating an old plan failure in a development environment.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
github-actions, terraform
Domaine
ci-cd, devops, tooling
Type d'issue
Fonctionnalité
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
45/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.