abcxyz / abcxyz/github-metrics-aggregator

Pre-generate `github-webhook-secret`

未关闭
#256 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
Go
星标
16
派生
3
PR 合并指标
30 天内没有已合并 PR

描述

### TL;DR

When instantiating the module, v1 of `github-webhook-secret` is created. Then, README asks to generate this secret locally (32 char base64) and update the value in the cloud console (creating v2).

Since this value is not inserted anywhere else, I don't understand why Terraform can not create the "final" value directly as v1, removing the need for this manual step? I think it should be able to create an appropriate string with `random_password`.

### Detailed design

_No response_

### Alternatives considered

_No response_

### Additional information

Doing click-ops to update the secret values in Cloud Console is not great as it is not captured by Terraform.

This is also the case for the .pem secret, which presumably could also be imported into terraform, but I understand if this is a little trickier.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。