abbbi / abbbi/virtnbdbackup

Use nbd.connect_systemd_socket_activation to run nbdkit/qemu-nbd commands

Open
#58 1 comment 0 reactions 0 assignees View on GitHub
code-cleanup
Dominant language
Python
Stars
518
Forks
57
PR merge metrics
No merged PRs in 30d

Description

Currently using subprocess.* functions to run qemu-nbd. I think this can be simplified by using libnbd's builtin
connect_systemd_socket_activation and nbd.connect_command. Example:

https://github.com/libguestfs/libnbd/blob/master/python/examples/checksum.py#L35

and:

https://github.com/libguestfs/libnbd/blob/master/python/t/590-aio-copy.py#L122

```
09:51 abi: it's not connected with systemd except that they invented the protocol
09:51 it doesn't require systemd to be installed or running
```

Unfortunately there is currently no way to catch stderr, means if underlying command fails for some reason, errors cannot be
catched and written to logfile accordingly. Need to check if its possible to redirect errors for all commands to a logfile.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.