abbbi / abbbi/virtnbdbackup

Replace functionality for offline backup with -S option, make -S option default

未关闭
#188 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
code-cleanup enhancement
主要语言
Python
星标
518
派生
57
PR 合并指标
30 天内没有已合并 PR

描述

At the moment there are two ways for backing up offline virtual machines:

1) Use the offline backup functionality in virtnbdbackup where the code starts the NBD Service using qemu-nbd, only copy backup works with this mode
2) Use option -S which starts VM in non-operational mode and enables all backup modes to work correctly.

I think the situations where option 1) is the better way for backing up the virtual machine are very limited. I cant think of situations where the virtual machine is not able to be started in on-operational mode.

It may make sense to enable option -S by default and remove all the legacy code from the codebase that handles starting the local and remote qemu-nbd processes for the offline backup.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。