abbbi / abbbi/virtnbdbackup

Replace functionality for offline backup with -S option, make -S option default

Aperta
#188 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
code-cleanup enhancement
Lingua principale
Python
Stelle
518
Fork
57
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

At the moment there are two ways for backing up offline virtual machines:

1) Use the offline backup functionality in virtnbdbackup where the code starts the NBD Service using qemu-nbd, only copy backup works with this mode
2) Use option -S which starts VM in non-operational mode and enables all backup modes to work correctly.

I think the situations where option 1) is the better way for backing up the virtual machine are very limited. I cant think of situations where the virtual machine is not able to be started in on-operational mode.

It may make sense to enable option -S by default and remove all the legacy code from the codebase that handles starting the local and remote qemu-nbd processes for the offline backup.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.