aai-institute / aai-institute/pyDVL

Include shape in array types

未关闭
#541 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement good first issue
主要语言
Python
星标
146
派生
10
PR 合并指标
30 天内没有已合并 PR

描述

Using [nptyping and beartype](https://github.com/ramonhagenaars/nptyping/blob/master/USERDOCS.md#Quickstart) we can pin down the dimensions that we accept. For instance, the constructor of `ValuationResult` can only accept 1D arrays but we don't enforce that.

Alternatively, [jaxtyping](https://github.com/patrick-kidger/jaxtyping) supports jax, torch and numpy in one go. But python 3.9 is required so we'd have to wait until EOL for 3.8 at the very least.

Are there any other libraries?

贡献指南

打开贡献指南

调研方向

Look at the ValuationResult constructor to see how it currently handles arrays. Research nptyping and jaxtyping for shape enforcement. Check Python version constraints and project dependencies. Determine how to integrate a typing library to enforce 1D array dimensions in the constructor.

由索引模型根据 Issue 内容生成。

评估

技术栈
numpy, python
领域
backend-api-design, tooling
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。