aai-institute / aai-institute/lakefs-spec

[upstream] Tag names cannot contain spaces

Ouverte
#282 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
bug triage
Langage dominant
Python
Étoiles
65
Forks
7
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

### What happened?

Creating tags as such:

```py
with fs.transaction(repository.id) as tx:
sha = tx.rev_parse("main")
tag = tx.tag(sha, "v2 pipapo hello")
```

does not work because the lakeFS API rejects tag names containing spaces. It says

```
lakefs.exceptions.BadRequestException: code: 400, reason: Bad Request, body: {'message': 'argument tagID: tag id: invalid value: validation error'}
```
but with no mention as to what the validation mechanism (probably regex?) actually is. This would benefit from a bit of validation before sending the API request, to give the user a clearer idea of what actually went wrong.

IMO, it doesn't actually matter where that validation is happening, so it might as well be in lakeFS's Python wrapper project.

### What did you expect to happen?

The tag being created just fine.

### lakeFS-spec version

HEAD

### lakeFS version

latest

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.