Refactor: Centralize nested description reorder logic from ExperienceSection to useSectionManagement
- Linguagem predominante
- TypeScript
- Estrelas
- 6
- Forks
- 15
- Merge médio
- 7d 22h
- PRs com merge (30d)
- 2
Descrição
The reorder logic for nested description bullet points in ExperienceSection is implemented directly within the component (lines 230-242). This could be centralized in the useSectionManagement hook for cleaner separation of concerns.
Note: Entry-level reordering already uses the clean onReorderEntry callback pattern. This issue is specific to the nested description bullets within each experience entry.
Proposed Improvement
Introduce a specific callback prop for nested description reordering: onDescriptionReorder?: (experienceIndex: number, oldIndex: number, newIndex: number) => void
The parent hook (useSectionManagement) would encapsulate the state update logic, keeping ExperienceSection more presentational.
Scope
- Affected: ExperienceSection.tsx only
- Not affected: EducationSection.tsx (no nested draggables - already uses clean pattern)
Benefits
- Centralizes state management in hooks
- Makes components more presentational
- Creates a reusable pattern if future sections need nested draggables
References
- PR #205 review comment from gemini-code-assist
- File: resume-builder-ui/src/components/ExperienceSection.tsx (lines 230-242)
Guia de contribuição
Nenhum guia de contribuição indexado para este repositório
Direção de pesquisa
The work is in resume-builder-ui/src/components/ExperienceSection.tsx, specifically lines 230-242. Start by reading the existing reorder logic there and the useSectionManagement hook to understand the state management pattern. The goal is to extract the nested description reorder logic into the hook, creating a new callback prop `onDescriptionReorder` for the component. Check PR #205 for context. Verify the change by ensuring the drag-and-drop functionality for description bullet points still works.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- react
- Domínio
- frontend, tooling
- Tipo de issue
- Refatoração
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Status de atividade
- Estagnada
- Clareza
- Claramente especificada
- Facilidade para iniciantes
- 65/100