a8m / a8m/obj-parse

Enhancement Suggestion for obj-parse setterFn

Ouverte
#1 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
3
Forks
1
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Hi Ariel, first off thank you for obj-parse and deepkeys. Both are wonderful utilities that I am using in my project(s). I wanted to send you this change to setterFn, as it might be of benefit to others who would like to be able to handle key values which are functions:

``` javascript
var setterFn = function(scope, path, value) {
var s = scope;
for(var i = 0; i < path.length - 1; i++) { //check the path
s = s[path[i]]; // s is the current path segment
if(angular.isUndefined(s)) { //make sure the path segment is good/defined
return undefined;
}
}
//ok, we have a good path, if it is a vanilla value return that, or, if a function call it
//probably we could be more sophisticated and do something like value.call(scope,path,value)
//just use value() for now
s[path[i]] = (angular.isFunction(value) ? value() : value);
return scope; //return the updated scope
};
```

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.