a8m / a8m/angular-filter

"First" filter fails with expressions

未關閉
#78 6 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
2.9k
分支
319
PR 合併指標
30 天內沒有已合併 PR

描述

Given this data:

``` javascript
$scope.types = [
{
"name": "type1",
"default": false
},
{
"name": "type2",
"default": true
}
];
```

This failed:
`

`

I had to revert to:
`

`

As a test I also did:
`

`
but didn't seem to work either

This was working on 0.4.5 but not in 0.5.2

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

The issue is about the 'first' filter failing with expressions. Look at the filter implementation in the source code, likely in a file like 'first.js' or 'firstFilter.js'. Test the filter with the provided examples to reproduce the regression from version 0.4.5 to 0.5.2. Check the commit history around that version for changes to the filter logic. Ensure the fix allows expressions like 'default === true' and numeric arguments to work correctly.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
angularjs, javascript
領域
frontend
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
描述清楚
新手友好度
45/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。